Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update product mvp feature flag #36552

Merged
merged 4 commits into from Jan 23, 2023
Merged

Update product mvp feature flag #36552

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec11a60
Move product management feature to experimental and add additional note.
louwie17 Jan 23, 2023
1996dcc
Add changelog
louwie17 Jan 23, 2023
07b5913
Remove tooltip
louwie17 Jan 23, 2023
4e92706
Fix lint error
louwie17 Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/update-product_mvp_feature_flag
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: minor
Type: update

Move product management feature flag down to experimental.
7 changes: 5 additions & 2 deletions plugins/woocommerce/src/Internal/Features/FeaturesController.php
View file
Open in desktop
Expand Up @@ -104,8 +104,7 @@ public function __construct() {
'new_product_management' => array(
'name' => __( 'New product editor', 'woocommerce' ),
'description' => __( 'Try the new product editor (Beta)', 'woocommerce' ),
'tooltip' => __( 'Enable to try the new, simplified product editor (currently in development and only available for simple products). No extension support yet.', 'woocommerce' ),
'is_experimental' => false,
'is_experimental' => true,
),
'custom_order_tables' => array(
'name' => __( 'High-Performance order storage (COT)', 'woocommerce' ),
Expand Down Expand Up @@ -621,6 +620,10 @@ private function get_setting_for_feature( string $feature_id, array $feature, bo
}
}

if ( 'new_product_management' === $feature_id ) {
$desc_tip = __( "⚠ This feature is currently in development and only available for simple products. No extension support yet.", 'woocommerce' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louwie17 I believe we should make it disabled as the HPOS and remove the tooltip for the time being. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-23 at 11 49 47

}

if ( ! $this->is_legacy_feature( $feature_id ) && ! $disabled && $this->verify_did_woocommerce_init() ) {
$plugin_info_for_feature = $this->get_compatible_plugins_for_feature( $feature_id, true );
$incompatibles = array_merge( $plugin_info_for_feature['incompatible'], $plugin_info_for_feature['uncertain'] );
Expand Down