Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark purchase tests skipped temporarily #36741

Merged
merged 2 commits into from Feb 2, 2023

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented Feb 2, 2023

All Submissions:

Changes proposed in this Pull Request:

This PR marks three failings tests skipped temporarily due to a change in the endpoint behavior

Slack thread: p1675353860926879-slack-C025EHY377G

How to test the changes in this Pull Request:

Run ./vendor/bin/phpunit tests/legacy/unit-tests/woocommerce-admin/features/onboarding-tasks/tasks/purchase.php make confirm the test passes.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 2, 2023
Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Test Results Summary

Commit SHA: ee56c5b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 12s
E2E Tests189006019517m 54s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants