Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable purchase unit tests and falling back to simply not display any prices when data is not available #38163

Merged
merged 3 commits into from May 10, 2023

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented May 8, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #37081.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. CI should pass
  2. Run wp option set --format=json _transient_wc_onboarding_product_data '{\"en_US\":{\"body\":\"\"}}'
  3. Go to Onboarding wizard > Product Types tab (/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=product-types)
  4. Observe that it only shows the product type names, not containing price symbols.

Before:
Screenshot 2023-05-08 at 20 37 44

After:

Screenshot 2023-05-08 at 20 37 06

@chihsuan chihsuan marked this pull request as ready for review May 8, 2023 12:38
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 8, 2023
@chihsuan chihsuan self-assigned this May 8, 2023
@chihsuan chihsuan requested review from a team, ilyasfoo and rjchow May 8, 2023 12:38
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Test Results Summary

Commit SHA: de58bb2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 53s
E2E Tests1870010019713m 27s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #38163 (de58bb2) into trunk (5b3666b) will increase coverage by 0.0%.
The diff coverage is 25.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             trunk   #38163   +/-   ##
========================================
  Coverage     51.2%    51.2%           
  Complexity   17417    17417           
========================================
  Files          440      440           
  Lines        80639    80635    -4     
========================================
- Hits         41312    41310    -2     
+ Misses       39327    39325    -2     
Impacted Files Coverage Δ
...ocommerce/includes/abstracts/abstract-wc-order.php 76.4% <ø> (ø)
...ommerce/includes/abstracts/abstract-wc-product.php 88.3% <ø> (ø)
...ocommerce/includes/admin/class-wc-admin-addons.php 0.0% <ø> (ø)
...ocommerce/includes/admin/class-wc-admin-status.php 14.5% <ø> (ø)
.../includes/admin/helper/class-wc-helper-updater.php 28.9% <ø> (ø)
...erce/includes/admin/importers/mappings/default.php 4.5% <0.0%> (ø)
...udes/admin/settings/class-wc-settings-products.php 98.6% <ø> (ø)
...lugins/woocommerce/includes/class-wc-countries.php 95.4% <ø> (ø)
plugins/woocommerce/includes/class-wc-coupon.php 73.9% <ø> (ø)
...woocommerce/includes/class-wc-frontend-scripts.php 0.0% <ø> (ø)
... and 12 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting around to this!

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM! 🚢

@chihsuan chihsuan merged commit 4ba276d into trunk May 10, 2023
22 of 23 checks passed
@chihsuan chihsuan deleted the update/reenable-purchase-unit-test branch May 10, 2023 02:31
@github-actions github-actions bot added this to the 7.8.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable Purchase unit tests
3 participants