New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable purchase unit tests and falling back to simply not display any prices when data is not available #38163
Conversation
Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: de58bb2
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38163 +/- ##
========================================
Coverage 51.2% 51.2%
Complexity 17417 17417
========================================
Files 440 440
Lines 80639 80635 -4
========================================
- Hits 41312 41310 -2
+ Misses 39327 39325 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting around to this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well, LGTM! 🚢
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #37081.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
wp option set --format=json _transient_wc_onboarding_product_data '{\"en_US\":{\"body\":\"\"}}'
Onboarding wizard > Product Types
tab (/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=product-types)Before:
After: