New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove accordion from "Other payment providers" in WC Pay Task #37205
Conversation
Test Results SummaryCommit SHA: 218e45d
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests well and looks good, thanks for getting to it so quickly! 🚢
probably need to rebase on the latest trunk for the pnpm fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on it! 👍 🚀
LGTM and tested well.
b3d4527
to
e453c90
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37205 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
Complexity 17191 17191
==========================================
Files 429 429
Lines 64845 64865 +20
==========================================
+ Hits 30275 30284 +9
- Misses 34570 34581 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thanks @chihsuan 🚀
All Submissions:
Changes proposed in this Pull Request:
Closes #37203.
Remove the accordion from "Other payment providers" in WC Pay Task and add proper space between sections.
How to test the changes in this Pull Request:
/wp-admin/admin.php?page=wc-settings
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: