Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: payment transaction processor images to payment recommendations #37230

Merged
merged 1 commit into from Mar 17, 2023

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Mar 15, 2023

All Submissions:

Changes proposed in this Pull Request:

Context: 165-gh-woocommerce/team-ghidorah

We'd like to be able to display images for the payment recommendations for each payment method provider.

At this point in time the images hasn't been finalised yet so the included images for PayPal are a temporary placeholder. Before merging we should remove the mapping from DefaultPaymentGateways.php, and implement the finalised set only in wccom's remote API.

How to test the changes in this Pull Request:

  1. Go through OBW, and then turn off Marketplace Suggestions settings in WooCommerce Settings > Advanced Settings
  2. Go to Payments task http://localhost:8888/wp-admin/admin.php?page=wc-admin&task=payments
  3. If Remove accordion from "Other payment providers" in WC Pay Task #37205 hasn't been merged yet you will need to click on "Other payment providers" to see the payment methods
  4. Observe that the images render as defined in DefaultPaymentGateways.php

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@rjchow rjchow force-pushed the add/payment-recommendations-images branch from eea4913 to fa1839d Compare March 15, 2023 07:30
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #37230 (d18fa6e) into trunk (0cf5677) will decrease coverage by 0.0%.
The diff coverage is 32.0%.

❗ Current head d18fa6e differs from pull request most recent head 5a947a2. Consider uploading reports for the commit 5a947a2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37230     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
  Complexity   17191    17191             
==========================================
  Files          429      429             
  Lines        64845    64865     +20     
==========================================
+ Hits         30275    30282      +7     
- Misses       34570    34583     +13     
Impacted Files Coverage Δ
...ugins/woocommerce/includes/class-wc-post-types.php 2.7% <0.0%> (-0.1%) ⬇️
...gins/woocommerce/includes/wc-product-functions.php 44.7% <100.0%> (+1.0%) ⬆️

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

Test Results Summary

Commit SHA: 5a947a2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 47s
E2E Tests1910010020117m 55s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow force-pushed the add/payment-recommendations-images branch from fa1839d to d18fa6e Compare March 15, 2023 08:30
chihsuan
chihsuan previously approved these changes Mar 16, 2023
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well. 👍

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work on this @rjchow ! 🚀

@rjchow rjchow merged commit 23b7942 into trunk Mar 17, 2023
17 of 18 checks passed
@rjchow rjchow deleted the add/payment-recommendations-images branch March 17, 2023 05:49
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants