New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: payment transaction processor images to payment recommendations #37230
Conversation
eea4913
to
fa1839d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37230 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
Complexity 17191 17191
==========================================
Files 429 429
Lines 64845 64865 +20
==========================================
+ Hits 30275 30282 +7
- Misses 34570 34583 +13
|
Test Results SummaryCommit SHA: 5a947a2
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
fa1839d
to
d18fa6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well. 👍
d18fa6e
to
5a947a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work on this @rjchow ! 🚀
All Submissions:
Changes proposed in this Pull Request:
Context: 165-gh-woocommerce/team-ghidorah
We'd like to be able to display images for the payment recommendations for each payment method provider.
At this point in time the images hasn't been finalised yet so the included images for PayPal are a temporary placeholder. Before merging we should remove the mapping from
DefaultPaymentGateways.php
, and implement the finalised set only in wccom's remote API.How to test the changes in this Pull Request:
DefaultPaymentGateways.php
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: