Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility around product editor tabs #37217

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

joshuatf
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds accessibility for keyboard only and non-sighted users to the product tabs. Note that follow-ups will address:

  • Placement of tabs in header (pending header PR)
  • Tests around tabs
  • Disabled tabs (pending decision on template layouts)

Screen Shot 2023-03-14 at 8 57 22 AM

Closes (part of) #37096 .

How to test the changes in this Pull Request:

  1. Open your favorite screen reader
  2. Enable the blocks product editor feature
  3. Navigate through the tabs using the tab key and arrow keys
  4. Make sure tab labels are announced and that you can navigate without issue

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team March 14, 2023 16:03
@joshuatf joshuatf self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #37217 (c4f1a0e) into trunk (0cf5677) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37217     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
  Complexity   17191    17191             
==========================================
  Files          429      429             
  Lines        64845    64862     +17     
==========================================
  Hits         30275    30275             
- Misses       34570    34587     +17     
Impacted Files Coverage Δ
...ugins/woocommerce/includes/class-wc-post-types.php 2.7% <0.0%> (-0.1%) ⬇️

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: c4f1a0e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 59s
E2E Tests189006019517m 59s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for working on this @joshuatf , this tested well!

@joshuatf joshuatf merged commit cb82998 into trunk Mar 15, 2023
@joshuatf joshuatf deleted the add/37096-accessibility branch March 15, 2023 18:50
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants