Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests around product block editor tabs #37225

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Add tests around product block editor tabs #37225

merged 5 commits into from
Mar 16, 2023

Conversation

joshuatf
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds tests around tabs and the tab block. Note that the context is mocked since I don't see a clear way to set context attributes from child components.

Closes #37096 .

How to test the changes in this Pull Request:

  1. Check that all tests pass.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team March 15, 2023 00:17
@joshuatf joshuatf self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #37225 (38702a5) into trunk (0cf5677) will decrease coverage by 0.0%.
The diff coverage is 23.7%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37225     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
- Complexity   17191    17192      +1     
==========================================
  Files          429      429             
  Lines        64845    64874     +29     
==========================================
+ Hits         30275    30284      +9     
- Misses       34570    34590     +20     
Impacted Files Coverage Δ
plugins/woocommerce/includes/class-wc-ajax.php 4.3% <0.0%> (-<0.1%) ⬇️
...ugins/woocommerce/includes/class-wc-post-types.php 2.7% <0.0%> (-0.1%) ⬇️
...ocommerce/includes/abstracts/abstract-wc-order.php 86.6% <50.0%> (-0.1%) ⬇️
...gins/woocommerce/includes/wc-product-functions.php 44.7% <100.0%> (+1.0%) ⬆️

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

Test Results Summary

Commit SHA: 38702a5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests1910010020113m 47s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Base automatically changed from add/37096-accessibility to trunk March 15, 2023 18:50
@joelclimbsthings joelclimbsthings requested review from joelclimbsthings and removed request for a team March 16, 2023 18:00
Copy link
Contributor

@joelclimbsthings joelclimbsthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, looks good! :shipit:

@joshuatf joshuatf merged commit 5ed070d into trunk Mar 16, 2023
@joshuatf joshuatf deleted the add/37096-tests branch March 16, 2023 21:46
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a tab block for rendering tabs
2 participants