-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests around product block editor tabs #37225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37225 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
- Complexity 17191 17192 +1
==========================================
Files 429 429
Lines 64845 64874 +29
==========================================
+ Hits 30275 30284 +9
- Misses 34570 34590 +20
|
Test Results SummaryCommit SHA: 38702a5
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
joshuatf
force-pushed
the
add/37096-tests
branch
from
March 15, 2023 20:52
20ecc4a
to
a326f2a
Compare
joshuatf
force-pushed
the
add/37096-tests
branch
from
March 16, 2023 17:09
b993b30
to
38702a5
Compare
joelclimbsthings
requested review from
joelclimbsthings
and removed request for
a team
March 16, 2023 18:00
joelclimbsthings
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adds tests around tabs and the tab block. Note that the context is mocked since I don't see a clear way to set context attributes from child components.
Closes #37096 .
How to test the changes in this Pull Request:
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: