Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox label styling on product page tabs #37791

Merged
merged 2 commits into from Apr 19, 2023
Merged

Conversation

mattsherman
Copy link
Contributor

@mattsherman mattsherman commented Apr 18, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes the styling of checkbox labels on the product page tabs for smaller viewports (max-width: 1280px).

This is not a new bug... it has existed since at least 2.5.0 (I went back to that version and could reproduce it). To be honest, I'm not really sure why a very visible issue like this hasn't been fixed ever. Maybe I'm one of the few that regularly use a smaller viewport?

Before

Screenshot 2023-04-18 at 10 04 42

After

Screenshot 2023-04-18 at 11 18 00

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Products > Add New (/wp-admin/post-new.php?post_type=product)
  2. Go to the Inventory tab
  3. Verify the checkboxes are displayed correctly on both larger and smaller viewports. The checkbox label should always start right next to the checkbox, never fully below it.

@mattsherman mattsherman added type: bug The issue is a confirmed bug. focus: product management Related to product creation and editing. labels Apr 18, 2023
@mattsherman mattsherman requested a review from a team April 18, 2023 15:22
@mattsherman mattsherman self-assigned this Apr 18, 2023
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 18, 2023
@github-actions
Copy link
Contributor

Hi , @woocommerce/mothra-enhancements

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: a0552e0

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 49s
E2E Tests1870010019715m 21s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman marked this pull request as ready for review April 18, 2023 15:54
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #37791 (a0552e0) into trunk (c226fa1) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37791     +/-   ##
==========================================
- Coverage     51.6%    51.6%   -0.0%     
- Complexity   17260    17261      +1     
==========================================
  Files          429      429             
  Lines        79928    79942     +14     
==========================================
- Hits         41213    41211      -2     
- Misses       38715    38731     +16     
Impacted Files Coverage Δ
...ocommerce/includes/admin/class-wc-admin-assets.php 0.0% <0.0%> (ø)
...ugins/woocommerce/includes/class-wc-post-types.php 1.1% <0.0%> (-<0.1%) ⬇️
...commerce/includes/class-wc-rest-authentication.php 3.4% <0.0%> (-<0.1%) ⬇️
plugins/woocommerce/includes/class-woocommerce.php 20.4% <ø> (ø)
...ludes/tracks/events/class-wc-products-tracking.php 0.0% <ø> (ø)
plugins/woocommerce/woocommerce.php 15.4% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@nathanss nathanss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proactivity!

@nathanss nathanss merged commit 1dd8e05 into trunk Apr 19, 2023
21 of 23 checks passed
@nathanss nathanss deleted the fix/checkbox-labels branch April 19, 2023 13:19
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants