New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkbox label styling on product page tabs #37791
Conversation
Hi , @woocommerce/mothra-enhancements Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: a0552e0
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37791 +/- ##
==========================================
- Coverage 51.6% 51.6% -0.0%
- Complexity 17260 17261 +1
==========================================
Files 429 429
Lines 79928 79942 +14
==========================================
- Hits 41213 41211 -2
- Misses 38715 38731 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the proactivity!
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes the styling of checkbox labels on the product page tabs for smaller viewports (
max-width: 1280px
).This is not a new bug... it has existed since at least
2.5.0
(I went back to that version and could reproduce it). To be honest, I'm not really sure why a very visible issue like this hasn't been fixed ever. Maybe I'm one of the few that regularly use a smaller viewport?Before
After
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/post-new.php?post_type=product
)