Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product data field description styling, including checkboxes and radio buttons #38066

Merged
merged 2 commits into from May 3, 2023

Conversation

mattsherman
Copy link
Contributor

@mattsherman mattsherman commented May 2, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR tweaks the fix originally supplied in #37791 to improve the product data field description styling, including checkbox and radio buttons. The previous fix, while addressing checkbox and radio buttons, made the styling of descriptions associated with other types of inputs worse on smaller viewports.

This updated implementation keeps the improvement of the checkbox and radio button label styling, and also improves the styling of descriptions associated with other types of inputs by always showing those descriptions below the corresponding input field, regardless of viewport width. This improves situations where the description is long and would wrap oddly before.

I resisted making changes to the structure of the HTML, since that may lead to unexpected issues for extensions. There is certainly a lot of room for improvement, but any such changes would need to be carefully considered.

Before

Screenshot 2023-05-01 at 21 15 34

Screenshot 2023-05-01 at 21 15 50

After

Screenshot 2023-05-01 at 21 08 33

Screenshot 2023-05-01 at 21 12 16

(No visual change to Inventory tab)

How to test the changes in this Pull Request:

  1. Go to Products > Add New (/wp-admin/post-new.php?post_type=product)
  2. Enable Downloadable
  3. Go to the General tab
  4. Verify the Schedule link is below the Sale price ($) field
  5. Verify the descriptions for Download limit and Download expiry are below the input field
  6. Go to the Inventory tab
  7. Verify the checkboxes are displayed correctly on both larger and smaller viewports. The checkbox label should always start right next to the checkbox, never fully below it. (This is no change over what was implemented in Fix checkbox label styling on product page tabs #37791)

@mattsherman mattsherman self-assigned this May 2, 2023
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Test Results Summary

Commit SHA: e717787

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 50s
E2E Tests1870010019713m 40s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman requested a review from a team May 2, 2023 01:25
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Hi @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@mattsherman mattsherman marked this pull request as ready for review May 2, 2023 01:25
@octaedro octaedro requested review from octaedro and removed request for a team May 3, 2023 13:22
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mattsherman! LGTM 🚀

@mattsherman mattsherman merged commit 865fcd0 into trunk May 3, 2023
20 checks passed
@mattsherman mattsherman deleted the fix/product-data-field-description-styling branch May 3, 2023 22:08
@github-actions github-actions bot added this to the 7.8.0 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants