Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use waitUntil instead of waitForLoadState in page.goto() #37831

Merged
merged 4 commits into from Apr 19, 2023
Merged

Fix: Use waitUntil instead of waitForLoadState in page.goto() #37831

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4174194
fix: use correct argument in playwright test
ravinderk Apr 19, 2023
deb366a
chore: add log for change
ravinderk Apr 19, 2023
b980454
chore: revert changes in e2e test
ravinderk Apr 19, 2023
24e83c2
Update analytics-overview.spec.js
lanej0 Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/fix-36698
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Use waitUntil instead of waitForLoadState in page.goto() and page.click().
4 changes: 2 additions & 2 deletions plugins/woocommerce/tests/e2e-pw/tests/admin-analytics/analytics-overview.spec.js
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ test.describe( 'Analytics pages', () => {
// do some cleanup after each test to make sure things are where they should be
await page.goto(
'wp-admin/admin.php?page=wc-admin&path=%2Fanalytics%2Foverview',
{ waitForLoadState: 'networkidle' }
{ waitUntil: 'networkidle' }
);
ravinderk marked this conversation as resolved.
Show resolved Hide resolved

// Grab all of the section headings
Expand Down Expand Up @@ -53,7 +53,7 @@ test.describe( 'Analytics pages', () => {
const arrExpectedSections = [ 'Charts', 'Leaderboards', 'Performance' ];
await page.goto(
'wp-admin/admin.php?page=wc-admin&path=%2Fanalytics%2Foverview',
{ waitForLoadState: 'networkidle' }
{ waitUntil: 'networkidle' }
);
ravinderk marked this conversation as resolved.
Show resolved Hide resolved

for ( const expectedSection of arrExpectedSections ) {
Expand Down