New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shipping tour layout context error #38183
Conversation
Hi @moon0326, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
1 similar comment
Hi @moon0326, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 47acae2
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fix 👍
LGTM and tested well 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, tested well, LGTM! 🚢
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #38112.
When I was investigating #38112, I found the shipping tour broken in the trunk branch. I think it's caused by #37720 refactoring.
LayoutContextProvider
doesn't exist in embedded-body-layout.This PR adds
LayoutContextProvider
to fix the issue.Besides, I updated the shipping tour to handle the option update error.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
United States
as your store countryReview shipping options
in theThings to do next task list
if it isn't shown as completed yet.woocommerce_admin_reviewed_default_shipping_zones
option.Shipping options
in the top