New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update task list documentation and example #38245
Conversation
Test Results SummaryCommit SHA: 2e85c9d
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
66f5d8c
to
73827b5
Compare
Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Thanks for updating the docs, @chihsuan! I wasn't able to run |
Sorry @ilyasfoo, could you please try again using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
It worked well with your revised comment 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @chihsuan!
I have minor comments, some comments are co-authored by ChatGPT:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM! 🚢
d085d8a
to
19b0eff
Compare
It seems like e2e tests are failing but unrelated to this PR. Wait for #38321. |
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
19b0eff
to
2e85c9d
Compare
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #35234.
This PR updates the task list documentation and example of "add task".
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WC_EXT=add-task pnpm --filter=woocommerce/client/admin example
.wp-env.json
or.wp-env.override.json
and restart the WordPress instanceWooCommerce > Home