New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup task list and re-organize file structure #38271
Conversation
Hi @moon0326, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 81fcbee
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38271 +/- ##
==========================================
+ Coverage 51.2% 51.5% +0.3%
- Complexity 17439 17443 +4
==========================================
Files 440 440
Lines 80722 80290 -432
==========================================
Hits 41348 41348
+ Misses 39374 38942 -432
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on it 👍
LGTM and everything worked as expected on WooCommerce Home 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well and the new folder layout is much nicer. Love to see a negative code line diff in a PR! 🚀
Submission Review Guidelines:
Changes proposed in this Pull Request:
While updating the task list document, I noticed that we have many outdated code that can be removed or deprecated, including task snooze APIs and old two-column experiment code.
Besides, we have three folders related to the task lists, which is very confusing. 😕
tasks
: include task list entry filetask-lists
: only contains progress title and headertwo-column-tasks
: It's acutally setup task list, not related to two-columns.Thus, this PR makes the following changes:
two-column
experiment code in the task list (in both backend and frontend)./client/tasks
folder into./client/task-lists
To express what it actually is.two-column-tasks
tosetup-task-list
and also move it into./client/task-lists
folder./task-lists/components
folderAfter merging this, we can find all frontend task list files in ./client/task-lists/ directory.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce > Home