Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPOS: Add descriptive document titles to HPOS order admin screens #38617

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

coreymckrill
Copy link
Collaborator

Changes proposed in this Pull Request:

Updates the <title> tag on Orders admin screens to more closely match what is used for CPT order screens. One slight difference is that on the Edit order screen, the HPOS title will show the order ID number instead of the order date.

How to test the changes in this Pull Request:

  1. Check the behavior on trunk before checking out this branch.
  2. Ensure that the HPOS feature is turned on (WooCommerce > Settings > Features) but have the posts table set as authoritative.
  3. View the orders list table screen and note the title of the document (usually shown in the "tab" part of a browser tab).
  4. Do the same for the Edit order screen and the Add new order screen.
  5. Now change the HPOS settings to make the customer order tables authoritative.
  6. View the same orders screens and note that all of them show the same thing instead of being relevant to the current screen.
  7. Now check out this branch and repeat the process. The document titles on the Edit and Add new screens show now be similar regardless of which HPOS mode is used.

@coreymckrill coreymckrill self-assigned this Jun 6, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 6, 2023
@coreymckrill coreymckrill requested review from a team and jorgeatorres and removed request for a team June 6, 2023 01:15
@coreymckrill coreymckrill marked this pull request as ready for review June 6, 2023 01:15
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Hi @jorgeatorres,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Test Results Summary

Commit SHA: a146ed0

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 46s
E2E Tests1950010020516m 11s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @coreymckrill!

@jorgeatorres jorgeatorres merged commit 016d948 into trunk Jun 7, 2023
19 of 20 checks passed
@jorgeatorres jorgeatorres deleted the update/order-admin-page-titles branch June 7, 2023 16:28
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants