Fix PHP notice when outside of orders screens

[jorgeatorres]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

After merging #38617 I noticed a PHP notice started appearing on all screens:

While #38617 made this evident, this is IMHO a failure in our orders page controller, since its logic is executed on every page even when not viewing an orders-related screen.

This PR addresses this by returning early if we're not on an admin page with wc-orders in its slug.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Check out trunk.
2. Visit any page outside of the Orders screen.
3. Confirm that you see the PHP notice mentioned above:

4. Visit WC > Orders and confirm that the notice no longer appears.
5. Repeat the above steps on this branch, and confirm that the notice does not appear at any point.

[github-actions]

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: d21cd0b

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 49s
E2E Tests	195	0	0	10	0	205	15m 54s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[coreymckrill]

👍 Approving, but the extraneous files should be removed before merging. Thanks again for catching this notice @jorgeatorres

I also noticed from the PR screenshot that I forgot to update the version placeholder in the two wc_doing_it_wrong calls (currently x.x.x). Would it make sense to update those here? If not, I'll just open a separate PR.

[jorgeatorres]

Hey @coreymckrill! Thanks for the review. I did push some files by mistake, but those have been removed now. I've also updated the 'x.x.x' version numbers per your request.

You'll have to review again, though, as the change dismissed the previous review. Thanks again!