Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help panel links #38817

Merged
merged 2 commits into from Jun 20, 2023
Merged

Fix help panel links #38817

merged 2 commits into from Jun 20, 2023

Conversation

chihsuan
Copy link
Member

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38539.

This PR fixes "Inbox", "Stats Overview' and "Store management" links under "Help" panel on Home screen redirects to the wrong section.

Screenshot 2023-06-20 at 15 08 38

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to WooCommerce->Home
  2. Click on "Help" panel.
  3. Click on Inbox/Stats overview/Store Management options.
  4. Observe that it redirects to the respective section.

@chihsuan chihsuan marked this pull request as ready for review June 20, 2023 07:09
@chihsuan chihsuan self-assigned this Jun 20, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 20, 2023
@chihsuan chihsuan requested review from a team, moon0326 and rjchow June 20, 2023 07:09
@github-actions
Copy link
Contributor

Hi @moon0326, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

Test Results Summary

Commit SHA: 3d8f95c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 8s
E2E Tests1900018020815m 5s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, I checked the rest of the links and they are correct too.
Seems brittle however, I wonder if an e2e test here would help

@chihsuan
Copy link
Member Author

Tested well, I checked the rest of the links and they are correct too. Seems brittle however, I wonder if an e2e test here would help

Thanks for the review! @rjchow That’s a good thought. I'll see if it's easy to do, maybe create another issue.

@chihsuan chihsuan merged commit 9509ae8 into trunk Jun 20, 2023
20 of 21 checks passed
@chihsuan chihsuan deleted the fix/help-panel-links branch June 20, 2023 10:11
@github-actions github-actions bot added this to the 8.0.0 milestone Jun 20, 2023
@ilyasfoo
Copy link
Contributor

I think adding an e2e to check an external system would not be ideal since it may break at anytime and other folks would wonder why.

@chihsuan
Copy link
Member Author

I think adding an e2e to check an external system would not be ideal since it may break at anytime and other folks would wonder why.

Good point! I just added an HTML comment on that page to indicate that if someone has made any changes to the order of sections, please notify us in #woo-start-manage to update the links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
3 participants