New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix help panel links #38817
Fix help panel links #38817
Conversation
Hi @moon0326, @rjchow, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 3d8f95c
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well, I checked the rest of the links and they are correct too.
Seems brittle however, I wonder if an e2e test here would help
Thanks for the review! @rjchow That’s a good thought. I'll see if it's easy to do, maybe create another issue. |
I think adding an e2e to check an external system would not be ideal since it may break at anytime and other folks would wonder why. |
Good point! I just added an HTML comment on that page to indicate that if someone has made any changes to the order of sections, please notify us in #woo-start-manage to update the links. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #38539.
This PR fixes "Inbox", "Stats Overview' and "Store management" links under "Help" panel on Home screen redirects to the wrong section.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce->Home