Update README.md php minimum version #39777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To version 7.3. This is the minimum from WooCommerce 7.7
jconroy
requested review from
a team and
rrennick
and removed request for
a team
|
Hi @rrennick, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: bc95418
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
rrennick
approved these changes
Aug 21, 2023
added 2 commits
August 21, 2023 14:16
rrennick
force-pushed
the
fix/readme-php-version
branch
from
dcd9e60
to
c8dc567
Compare
rrennick
force-pushed
the
fix/readme-php-version
branch
from
c8dc567
to
10094d6
Compare
|
Aha, and I'm already behind #39820 lol |
budzanowski
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor text change - updates the README.md to mention php version 7.3. This is the minimum from WooCommerce 7.7 I believe
https://woocommerce.com/document/server-requirements/
Submission Review Guidelines:
Changes proposed in this Pull Request:
Updates README.md - nothing significant
How to test the changes in this Pull Request:
View README.md - check that php version mentioned is 7.3, not 7.2
Changelog entry
Significance
Type
Message
Comment
Simply updates the README.md - I don't think this needs a changelog entry