Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump WooCommerce minimum required PHP version to 7.4 #39820

Merged
merged 7 commits into from Aug 22, 2023
Merged

Bump WooCommerce minimum required PHP version to 7.4 #39820

merged 7 commits into from Aug 22, 2023

Conversation

Konamiman
Copy link
Contributor

@Konamiman Konamiman commented Aug 21, 2023 •
edited

Changes proposed in this Pull Request:

As announced in the WooCommerce developer blog:

Bump the required PHP version of WooCommerce from 7.3 to 7.4

  • Change "Requires PHP":
    • In woocommerce.php
    • In readme.txt
    • In plugins/woocommerce-docs/woocommerce-docs.php
    • In packages/js/create-product-editor-block/plugin-templates/$slug.php.mustache
  • Change "testVersion" in phpcs.xml:
    • In the root of the repository
    • In plugins/woocommerce
    • In plugins/woocommerce-beta-tester
  • Change "require-php" and "config-platform-php" in composer.json
  • Update composer.lock with more modern versions of some of the dependencies
  • Remove the admin notice about the upcoming bump for PHP 7.3 users in class-wc-admin-notices.php

How to test the changes in this Pull Request:

Test that WooCommerce works and the unit tests still pass. No the best testing instructions ever, but that's pretty much it.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Bump required PHP version to 7.4

Comment

@Konamiman
Bump WooCommerce minimum required PHP version to 7.4
8bd00ef 
This includes:

- Changing "Requires PHP" in woocommerce.php
- Changing "Requires PHP" in readme.txt
- Changing "require-php" and "config-platform-php" in composer.json
- Changing "testVersion" in phpcs.xml
- Updating the composer.lock file with more modern versions
  of some of the dependencies
@Konamiman
Remove the admin notice about the upcoming PHP 7.4 requirement
1115f26
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Aug 21, 2023
@Konamiman Konamiman self-assigned this Aug 21, 2023
@Konamiman Konamiman requested a review from lsinger August 21, 2023 09:59
@github-actions
Copy link
Contributor

Hi @lsinger,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@lsinger lsinger closed this Aug 21, 2023
@lsinger lsinger reopened this Aug 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023 •
edited

Test Results Summary

Commit SHA: 589615f

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 5s
E2E Tests1950015021015m 6s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

lsinger
lsinger suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@lsinger lsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this, @Konamiman!

Looks good, but I do have a few notes and questions:

  • let's also update the PHP version in the monorepo root’s phpcs.xml.
  • let's also update 7.3 to 7.4 in plugins/woocommerce/readme.txt (down in the prose)
  • should we also update phpcs.xml for woocommerce-beta-tester?
  • should we also update plugins/woocommerce-docs/woocommerce-docs.php?
  • not sure if packages/js/create-product-editor-block/plugin-templates/$slug.php.mustache should also be updated -- there's little point in keeping it at 7.3 I suppose? cc @mattsherman

@Konamiman
Change required PHP version to 7.4 in some more places:
8e7c81f 
- "testVersion" in phpcs.xml in the root of the repo
- "testVersion" in phpcs.xml in plugins/woocommerce-beta-tester
- "Requires PHP" in plugins/woocommerce-docs/woocommerce-docs.php
- "Requires PHP" in packages/js/create-product-editor-block/plugin-templates/$slug.php.mustache
@github-actions github-actions bot added the plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. label Aug 21, 2023
@Konamiman Konamiman requested a review from lsinger August 21, 2023 11:01
Add changefile(s) from automation for the following project(s): @wooc…
ab47a6d 
…ommerce/create-product-editor-block, woocommerce-beta-tester, woocommerce
@lsinger lsinger closed this Aug 21, 2023
@lsinger lsinger reopened this Aug 21, 2023
jonathansadowski
jonathansadowski previously requested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as "request changes" for now just to remind you that the code freeze for 8.1 is today at 2300 UTC, and that we should hold off on merging this until after the freeze, as we communicated that this wouldn't land until 8.2.

Feel free to dismiss this review once the freeze occurs 😄

@mattsherman
Copy link
Contributor

mattsherman commented Aug 21, 2023 •
edited

  • not sure if packages/js/create-product-editor-block/plugin-templates/$slug.php.mustache should also be updated -- there's little point in keeping it at 7.3 I suppose? cc @mattsherman

We should update that template file to be 7.4 as we are WooCommerce, as it doesn't really make sense to have it be lower than the minimum required version for WooCommerce.

@Konamiman Konamiman merged commit 4876ab3 into trunk Aug 22, 2023
26 checks passed
@Konamiman Konamiman deleted the bump-required-php-to-7.4 branch August 22, 2023 07:21
@github-actions github-actions bot added this to the 8.2.0 milestone Aug 22, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 22, 2023
@lsinger
Copy link
Contributor

lsinger commented Aug 22, 2023

  • not sure if packages/js/create-product-editor-block/plugin-templates/$slug.php.mustache should also be updated -- there's little point in keeping it at 7.3 I suppose? cc @mattsherman

We should update that template file to be 7.4 as we are WooCommerce, as it doesn't really make sense to have it be lower than the minimum required version for WooCommerce.

Thanks for confirming, @mattsherman, I thought as much. It's included in this PR.

@nigeljamesstevenson nigeljamesstevenson removed the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 22, 2023
@nigeljamesstevenson nigeljamesstevenson added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris labels Aug 22, 2023
rrennick pushed a commit that referenced this pull request Aug 22, 2023
bump to 7.4 see #39820
0c133fd
@jconroy jconroy mentioned this pull request Aug 23, 2023
Merged
11 tasks
samueljseay pushed a commit that referenced this pull request Aug 23, 2023
@Konamiman @samueljseay
Bump WooCommerce minimum required PHP version to 7.4 (#39820)
4152135 
-Change "Requires PHP":
  - In woocommerce.php
  - In readme.txt
  - In plugins/woocommerce-docs/woocommerce-docs.php
  - In packages/js/create-product-editor-block/plugin-templates/$slug.php.mustache

- Change "testVersion" in phpcs.xml:
  - In the root of the repository
  - In plugins/woocommerce
  - In plugins/woocommerce-beta-tester

- Change "require-php" and "config-platform-php" in composer.json
- Update composer.lock with more modern versions of some of the dependencies
- Remove the admin notice about the upcoming bump for PHP 7.3 users in class-wc-admin-notices.php
@krutidugade krutidugade mentioned this pull request Aug 25, 2023
Merged
@lsinger lsinger mentioned this pull request Sep 7, 2023
Merged
@JPry JPry mentioned this pull request Sep 8, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsinger lsinger lsinger approved these changes

@jonathansadowski jonathansadowski jonathansadowski left review comments

Assignees

@Konamiman Konamiman

Labels
needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Konamiman @mattsherman @lsinger @jonathansadowski @nigeljamesstevenson