Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HPOS by default for new installs. #40296

Merged
merged 1 commit into from Sep 20, 2023

Conversation

vedanshujain
Copy link
Contributor

@vedanshujain vedanshujain commented Sep 20, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Enables HPOS on new sites by default, if they don't have any incompatible plugin present.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

We will test for 1. new site with no incompatible plugins, 2. new site with incompatible plugin, 3. existing site with posts authoritative but no incompatible plugin.

New site with no incompatible plugin:

  1. Install the ZIP from this PR on a new site that doesn't have WooCommerce already.
  2. Activate WooCommerce and check that HPOS is authoritative, and that sync is disabled.

New site with incompatible plugin:

  1. On a new site without WooCommerce, add an incompatible plugin such WC smooth generator version 1.0.3 -> https://github.com/woocommerce/wc-smooth-generator/releases/tag/1.0.3
  2. Upload when WooCommerce zip from this PR.
  3. Activate WooCommerce that checks that posts are authoritative.

Existing site with posts authoritative and with or without incompatible plugins

  1. On an existing site with posts authoritative, upload this zip as an upgrade.
  2. Check that posts are still authoritative, and no changes to HPOS settings are made.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Test Results Summary

Commit SHA: 6f4eb37

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 14s
E2E Tests205007021219m 13s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@vedanshujain vedanshujain marked this pull request as ready for review September 20, 2023 09:59
@vedanshujain vedanshujain added release: highlight Issues that have a high user impact and need to be discussed/paid attention to. impact: high Indicates if the PR has been determined as high impact. labels Sep 20, 2023
@Konamiman Konamiman self-requested a review September 20, 2023 10:17
@github-actions
Copy link
Contributor

Hi @Konamiman,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@Konamiman Konamiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the three scenarios described in the testing instructions in different Jurassic Ninja sites, intsalling WooCommerce via the WordPress plugin management UI, and everything works as expected. @jorgeatorres has tested as well installing WooCommerce using the WP CLI tool, and everything worked well too.

@Konamiman Konamiman added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Sep 20, 2023
@nigeljamesstevenson nigeljamesstevenson added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Sep 20, 2023
@nigeljamesstevenson
Copy link
Contributor

Thanks for the quick turnaround on this! I have assigned this one for Internal and External testing as per the p1695155631985529/1695113751.041879-slack-C0E1AV8T0

@nigeljamesstevenson nigeljamesstevenson merged commit 6b4bec0 into trunk Sep 20, 2023
33 of 34 checks passed
@nigeljamesstevenson nigeljamesstevenson deleted the add/hpos_by_default branch September 20, 2023 14:04
@github-actions github-actions bot added this to the 8.2.0 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: high Indicates if the PR has been determined as high impact. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. release: highlight Issues that have a high user impact and need to be discussed/paid attention to. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants