New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable HPOS by default for new installs. #40296
Conversation
Test Results SummaryCommit SHA: 6f4eb37
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hi @Konamiman, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
91b1fed
to
6f4eb37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the three scenarios described in the testing instructions in different Jurassic Ninja sites, intsalling WooCommerce via the WordPress plugin management UI, and everything works as expected. @jorgeatorres has tested as well installing WooCommerce using the WP CLI tool, and everything worked well too.
Thanks for the quick turnaround on this! I have assigned this one for Internal and External testing as per the p1695155631985529/1695113751.041879-slack-C0E1AV8T0 |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Enables HPOS on new sites by default, if they don't have any incompatible plugin present.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
We will test for 1. new site with no incompatible plugins, 2. new site with incompatible plugin, 3. existing site with posts authoritative but no incompatible plugin.
New site with no incompatible plugin:
New site with incompatible plugin:
Existing site with posts authoritative and with or without incompatible plugins
Changelog entry
Significance
Type
Message
Comment