Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct feature name for back compat. #40367

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Use correct feature name for back compat. #40367

merged 2 commits into from
Sep 22, 2023

Conversation

vedanshujain
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

We used the custom_order_tables everywhere for extensions to declare compatibility, instead of the option name. I accidentally added the option name in #40296 in one of the pre-flight checks. This means that HPOS would only be enabled by default only for those new sites, that do not already have any WC-related extension installed.

This fix includes those sites that have WC extensions installed before WC itself, as long as they are declared compatible with HPOS.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. On a new site, that never had WooCommerce installed, install an HPOS-compatible WC extension such as WooCommerce PayPal Payments
  2. Install and activate WooCommerce from a zipped build with this PR.
  3. Check that HPOS is authoritative by going to WooCommerce > Settings > Advanced > Features.

Also, it would be good to test out cases listed in #40296 to prevent regressionl.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 22, 2023
@vedanshujain vedanshujain marked this pull request as ready for review September 22, 2023 09:29
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 0afde90

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 3s
E2E Tests205007021219m 56s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@Konamiman Konamiman self-requested a review September 22, 2023 11:05
@github-actions
Copy link
Contributor

Hi @Konamiman,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@Konamiman Konamiman merged commit 94069bb into trunk Sep 22, 2023
28 checks passed
@Konamiman Konamiman deleted the fix/feature_name branch September 22, 2023 14:04
@github-actions github-actions bot added this to the 8.3.0 milestone Sep 22, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Sep 22, 2023
@alopezari alopezari added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Sep 22, 2023
@jonathansadowski jonathansadowski modified the milestones: 8.3.0, 8.2.0 Sep 25, 2023
jonathansadowski pushed a commit that referenced this pull request Sep 25, 2023
* Use correct feature name for back compat. (#40367)

* Prep for cherry pick 40367

---------

Co-authored-by: Vedanshu Jain <vedanshu.jain.2012@gmail.com>
Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants