-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Customization > Update the position for patterns on templates two and three #41551
Conversation
Hi @chihsuan, @adrianduffell, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 80fa3f5
Please address the following issues prior to merging this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Confirmed homepage templates shown as expected. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@nefeline Do you still plan to merge this?
Hi @adrianduffell ! No: I'm closing this one out as the designs ended up changing & we have adopted #44616 instead. Thanks for the review here anyways! |
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR updates the order of the patterns for templates 2 and 3 in the Customize Your Store (CYS) flow, as requested by design.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Make sure you are testing this with a Jetpack connected instance of WooCommerce, as the AI text completion endpoint can only be called with a Jetpack connected account.
demo_new_patterns.mov
Note that AI dynamically changes the images and content, so those are not expected to be an exact match when compared with the video. You may notice some oddities with spacing between patterns on Template 3: this will be changed at the pattern level on WooCommerce Blocks.
Changelog entry
Significance
Type
Message
Update the order of the patterns for templates in the Customize Your Store flow
Comment