Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Customization > Update the position for patterns on templates two and three #41551

Closed
wants to merge 4 commits into from

Conversation

nefeline
Copy link
Member

@nefeline nefeline commented Nov 17, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR updates the order of the patterns for templates 2 and 3 in the Customize Your Store (CYS) flow, as requested by design.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Make sure you are testing this with a Jetpack connected instance of WooCommerce, as the AI text completion endpoint can only be called with a Jetpack connected account.

  1. Create a new WooCommerce installation with this version.
  2. Install and activate the WooCommerce Blocks plugin from this zip file: woocommerce-gutenberg-products-block.zip
  3. Make sure to enable customize-store feature flag
  4. Go to WooCommerce -> Home and click Customize Store task
  5. Click Design with AI button
  6. Fill out a business description and proceed
  7. From the Assembler sidebar, click on "Change Your Homepage":
Screenshot 2023-10-04 at 20 08 15
  1. Make sure you can visualize all three homepage templates as expected, and the patterns for the second and third templates are as follows:
demo_new_patterns.mov

Note that AI dynamically changes the images and content, so those are not expected to be an exact match when compared with the video. You may notice some oddities with spacing between patterns on Template 3: this will be changed at the pattern level on WooCommerce Blocks.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Update the order of the patterns for templates in the Customize Your Store flow

Comment

@nefeline nefeline self-assigned this Nov 17, 2023
@nefeline nefeline added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 17, 2023
Copy link
Contributor

github-actions bot commented Nov 17, 2023

Hi @chihsuan, @adrianduffell,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Test Results Summary

Commit SHA: 80fa3f5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 35s
E2E Tests254017026221m 22s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Confirmed homepage templates shown as expected. 👍

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nefeline Do you still plan to merge this?

@nefeline
Copy link
Member Author

@nefeline Do you still plan to merge this?

Hi @adrianduffell ! No: I'm closing this one out as the designs ended up changing & we have adopted #44616 instead. Thanks for the review here anyways!

@nefeline nefeline closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants