New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS on Core] Update homepage templates intro patterns #44616
Conversation
Test Results SummaryCommit SHA: 9b46a03
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hi @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Things are a-ok on core, but on WooExpress I've noticed some differences: left a comment to confirm 👍
plugins/woocommerce-admin/client/customize-store/data/homepageTemplates.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 !
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR updates the intro patterns for Core in the first and second homepages of the CYS flow.
It also adds bottom margin to the
Just Arrived Full Hero
and increases the height of theFeatured Category Cover Image
to match the designs.Closes #44614
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Local/JN
WooCommerce Beta Tester
plugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.wp-admin/admin.php?page=wc-admin&path=/customize-store
.Customize your store
and finish the flow.Just Arrived Full Hero
👇Click on
Change your homepage
and click on the second homepage available.Check the first pattern after the header is the
Featured Category Cover Image
👇Hero Product Split
👇WooExpress
WooCommerce Beta Tester
plugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.wp-admin/admin.php?page=wc-admin&path=/customize-store
.Customize your store
and finish the flow.Change your homepage
.Hero Product Split
👇Changelog entry
Significance
Type
Message
Comment