Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS on Core] Update homepage templates intro patterns #44616

Merged
merged 6 commits into from Feb 16, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Feb 14, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR updates the intro patterns for Core in the first and second homepages of the CYS flow.
It also adds bottom margin to the Just Arrived Full Hero and increases the height of the Featured Category Cover Image to match the designs.

Closes #44614

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Local/JN

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  4. Click on Customize your store and finish the flow.
  5. Check the first pattern after the header is the Just Arrived Full Hero 👇
Screenshot 2024-02-14 at 16 15 12
  1. Click on Change your homepage and click on the second homepage available.

  2. Check the first pattern after the header is the Featured Category Cover Image 👇

Screenshot 2024-02-14 at 16 15 42
  1. Click on the third homepage option.
  2. Check the first pattern after the header is the Hero Product Split 👇
Screenshot 2024-02-14 at 16 40 54

WooExpress

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  4. Click on Customize your store and finish the flow.
  5. Click on Change your homepage.
  6. Check that in the 3 available homepages the first pattern after the header is the Hero Product Split 👇
Screenshot 2024-02-14 at 16 40 54

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 14, 2024
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Test Results Summary

Commit SHA: 9b46a03

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests2720053032510m 28s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin albarin marked this pull request as ready for review February 14, 2024 15:40
@woocommercebot woocommercebot requested review from a team and nefeline and removed request for a team February 14, 2024 15:45
Copy link
Contributor

Hi @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Things are a-ok on core, but on WooExpress I've noticed some differences: left a comment to confirm 👍

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 !

@albarin albarin merged commit 2d2d626 into trunk Feb 16, 2024
64 checks passed
@albarin albarin deleted the 44614-update-homepage-templates branch February 16, 2024 13:59
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 16, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 16, 2024
@Stojdza Stojdza added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on Core] Update homepage templates intro patterns
3 participants