New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate cookie headers from the response #42828
Conversation
Test Results SummaryCommit SHA: 3bbb2ed
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
a5360ae
to
3f26ca0
Compare
Hi @opr, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
e9bac25
to
3bbb2ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for me! Thanks Mike. Tests not passing though (unrelated) so waiting for a resolution before merging.
Submission Review Guidelines:
Changes proposed in this Pull Request:
When adding multiple products to the cart programmatically, 2 headers are added per item. This PR ensures that duplicate headers are removed to prevent this occuring.
Closes #39670
How to test the changes in this Pull Request:
Developers:
To test this you can add the following code to your site somewhere. This will add 5 products to your cart when you visit any page, then redirect to the homepage.
After this you can use browser tools to see what headers came back in the response:
Non-developers:
Changelog entry
Significance
Type
Message
Remove duplicate cookie headers from the response when adding multiple items to the cart programmatically.
Comment