New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit cookie dedupe logic to only WooCommerce Cart cookies #43504
Conversation
Hi @mikejolley, @woocommerce/rubik Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 0aec6a6
Please address the following issues prior to merging this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with and without the new code after the latest commit; seems to work as intended. The session cookie was only created once.
* limit check to only Woo cookies * limit logic to woo cookies only * add changelog * no need for set-cookie prefix
* Limit cookie dedupe logic to only WooCommerce Cart cookies (#43504) * limit check to only Woo cookies * limit logic to woo cookies only * add changelog * no need for set-cookie prefix * Prep for cherry pick 43504 --------- Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: WooCommerce Bot <no-reply@woo.com>
* limit check to only Woo cookies * limit logic to woo cookies only * add changelog * no need for set-cookie prefix
* Limit cookie dedupe logic to only WooCommerce Cart cookies (#43504) * limit check to only Woo cookies * limit logic to woo cookies only * add changelog * no need for set-cookie prefix * Prep for cherry pick 43504 --------- Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: WooCommerce Bot <no-reply@woo.com>
Submission Review Guidelines:
Changes proposed in this Pull Request:
Builds from #42828 but only limit the logic to WooCommerce cookies.
Closes #43463
How to test the changes in this Pull Request:
Like #42828 use this updated snippet
Changelog entry
Significance
Type
Message
Comment