Add e2e tests to verify specific theme templates have priority over user-modified Product Catalog template #43750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
focus: template
Aljullu
force-pushed
the
add/theme-block-template-customization-ii
branch
from
126d3f0
to
d7fa39e
Compare
github-actions
bot
added
the
plugin: woocommerce
Test Results SummaryCommit SHA: dd59c7b
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
|
Hi @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Base automatically changed from
add/theme-block-template-customization
to
trunk
January 18, 2024 10:39
…ser-modified Product Catalog template
Aljullu
force-pushed
the
add/theme-block-template-customization-ii
branch
from
d7fa39e
to
dd59c7b
Compare
github-actions
bot
added
the
needs: analysis
nigeljamesstevenson
added
status: analysis complete
opr
pushed a commit
that referenced
this pull request
Jan 25, 2024
…ser-modified Product Catalog template (#43750) * Add e2e tests to verify specific theme templates have priority over user-modified Product Catalog template * Add changefile(s) from automation for the following project(s): woocommerce-blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Based on #43650.
Part of #43416.
This PR adds some tests to verify that if the theme has a specific template for Products by Category/Tag/Attribute, that one has priority over a Product Catalog template edited by the user.
(For context: if the theme doesn't have a specific template for Products by Category/Tag/Attribute and the user hasn't modified those templates, they default to the Product Catalog template, tests for this were added in #43471)
How to test the changes in this Pull Request:
Note: no need to test this for the release.
Changelog entry
Significance
Type
Message
Comment
Add e2e tests to verify specific theme templates have priority over user-modified Product Catalog template