New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e tests to verify block templates can be customized if the theme has its own custom templates #43650
Conversation
Test Results SummaryCommit SHA: af23dd2
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
2856b12
to
00c77e2
Compare
…orkflows/playwright.yml file
Hi @imanish003, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
1 similar comment
Hi @imanish003, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding E2E tests for the theme with custom templates 🙌🏻.
I've tested them locally and everything passed on my end. I've left a few minor suggestions in the review. Please feel free to overlook any nitpicks that don't resonate with you. However, there's one change regarding the “Hello World in the template” string that I believe is necessary.
Additionally, I'm not sure why, but when I run npm run test:e2e:side-effects
, it seems to execute all tests, which is puzzling. Are you experiencing the same issue?
...-blocks/tests/e2e/tests/templates/mini-cart-template-part.block_theme_with_templates.spec.ts
Outdated
Show resolved
Hide resolved
...blocks/tests/e2e/tests/templates/product-catalog-template.block_theme_with_templates.spec.ts
Outdated
Show resolved
Hide resolved
...blocks/tests/e2e/tests/templates/product-catalog-template.block_theme_with_templates.spec.ts
Outdated
Show resolved
Hide resolved
...tests/e2e/tests/templates/product-search-results-template.block_theme_with_templates.spec.ts
Outdated
Show resolved
Hide resolved
...s/tests/e2e/tests/templates/products-by-category-template.block_theme_with_templates.spec.ts
Outdated
Show resolved
Hide resolved
…with_templates.spec.ts
Thanks for all the useful suggestions, @imanish003! I implemented most of the changes, so this is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for quickly making the changes. I've left one minor comment, but I'm pre-approving the PR. Everything else looks great 🚀
Changes proposed in this Pull Request:
This PR:
package.json
scripts and some docs that were not up to date.plugins/woocommerce-blocks/.github/workflows/playwright.yml
, as I understand, that file has been superseded by.github/workflows/blocks-playwright.yml
.Part of #43416.
How to test the changes in this Pull Request:
Note: no need to test this for the release.
npm run test:e2e:side-effects
,npm run test:e2e:side-effects:report
,npm run test:e2e:classic-theme
,npm run test:e2e:classic-theme:report
,npm run test:e2e:block-theme-with-templates
andnpm run test:e2e:block-theme-with-templates:report
and verify all of them work (the report ones should open the report in your browser once finished).Changelog entry
Significance
Type
Message
Comment
Add e2e tests to verify block templates can be customized if the theme has its own custom templates.