Add wireit build config for woo-ai plugin

[jonathansadowski]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This PR adds wireit config to @woocommerce/plugin-woo-ai project, along with configs for both build and build watch.

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Try out pnpm --filter='@woocommerce/plugin-woo-ai' build
2. Repeat the previous command without changes to verify output is cached and not re-run
3. Try out pnpm --filter='@woocommerce/plugin-woo-ai' watch:build

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

This PR only affects build tooling and no change entry is required.

[github-actions]

Hi @retrofox, @ObliviousHarmony, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @retrofox, @ObliviousHarmony, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: 7a6795c

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	296	0	0	3	0	299	6m 24s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[rrennick]

LGTM but I'll leave for one of the other reviewers to approve.

[retrofox]

LGTM!

Tested the first and next builds. Also, watch mode works as expected 🚀

[ObliviousHarmony]

Thanks for tackling this.

As an aside, it looks like I forgot to add the "ci" configuration to the Woo AI plugin. Would you mind adding that here too and then we can also see this in action in this PR?

[ObliviousHarmony]

We should probably just remove this entirely.

[jonathansadowski]

I'm not sure I follow, remove the build script, or something else?

[ObliviousHarmony]

I was highlighting the bottom build:admin line. We should remove build:admin and probably add the uglification step to the wireit build command.

[jonathansadowski]

I might be missing something here, but the uglify script is defined as:

"uglify": "rm -f $npm_package_assets_js_min && for f in $npm_package_assets_js_js; do file=${f%.js}; node_modules/.bin/uglifyjs $f -c -m > $file.min.js; done",

However, there's no config in the package.json for assets.js.min or assets.js.js. Is this step actually doing anything the way it's configured currently? cc @retrofox

[ObliviousHarmony]

Honestly since webpack is configured here we can just remove the uglification script entirely. Not only does the current command not actually do anything this is behavior that should just be configured in webpack.config.js if we want it.

[jonathansadowski]

As an aside, it looks like I forgot to add the "ci" configuration to the Woo AI plugin. Would you mind adding that here too and then we can also see this in action in this PR?

I added a config here as well, adding linting. There seem to be several issues with the style lint though. I was going to offer to try and tackle solving those, but then I realized that the changes to the scss would have to also be reflected elsewhere, and I'm not as familiar with the code in woo-ai. lint:fix was able to solve some of the issues, but not all of them.

@ObliviousHarmony can we perhaps break adding the config into a separate issue? The scope of the original PR was adding the build configuration. @retrofox would you be able to address the style linting issues in separate PR(s) so that I can add the lint config once those are resolved?

[ObliviousHarmony]

can we perhaps break adding the config into a separate issue? The scope of the original PR was adding the build configuration

You added the configuration for linting and I think that's totally fine here. Adding support for unit tests would be a much more involved process since this plugin isn't set up with wp-env for unit testing.

[jonathansadowski]

You added the configuration for linting and I think that's totally fine here. Adding support for unit tests would be a much more involved process since this plugin isn't set up with wp-env for unit testing.

Sorry, maybe I wasn't clear. This PR is currently blocked because if I merged it there would be several failing style lint issues (see above), and therefore linting would fail whenever the entire set of jobs was returned. I was proposing stripping that out and starting a separate PR. This PR didn't originally aim to address the CI configuration.

[ObliviousHarmony]

That's fine, do what you need to 😄