Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI config for woo-ai #44133

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Add CI config for woo-ai #44133

wants to merge 2 commits into from

Conversation

jonathansadowski
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR is a follow-up to #43769. As discussed in that PR, it was suggested that the ci-config be put in place for woo-ai so that linting checks could run on woo-ai as well as part of ci.

Those changes were removed from #43769, because there were several style lint issues that could not be auto-resolved. This PR should not be merged until the woo-ai linting issues are resolved, otherwise post-merge ci failures will occur, and there will also be failures on any PR that updates package.json.

/cc @retrofox as noted in #43769, I'm not as familiar with the issues causing the lint failures, so I'm adding you as a reviewer, but feel free to hand this off to somebody else if it's a better fit.

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a PR targeting this branch, based on this branch. That PR should change a file within woo-ai that matches the src/**/*.{js,jsx,ts,tsx} pattern from this config.
  2. Verify that the lint checks run.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

This PR only affects tooling and therefore no changelog entry is required.

Comment

@github-actions github-actions bot added the plugin: woo-ai Issues related to the Woo AI features plugin. label Jan 26, 2024
Copy link
Contributor

Hi @retrofox,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Test Results Summary

Commit SHA: de41cff

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests29000902996m 52s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woo-ai Issues related to the Woo AI features plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant