Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WC Blocks Playwright tests docs so we pass parameters correctly to PNPM scripts #43779

Merged
merged 1 commit into from Jan 22, 2024

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jan 18, 2024

Changes proposed in this Pull Request:

In #43650 we updated the WC Blocks Playwright docs to use pnpm instead of npm, but I didn't update how the parameters are passed, so they were ignored. I needed to change from:

pnpm run test:e2e -- --headed

to:

pnpm run test:e2e --headed

This PR fixes that.

How to test the changes in this Pull Request:

Note: no need to test this for the release.

  1. Inside the plugins/woocommerce-blocks folder, run pnpm run test:e2e --ui, pnpm run test:e2e --headed, pnpm run test:e2e --debug and verify all of them work as expected. Tip: no need to run all tests to verify the commands work, you can simply run one of them. Ie:
  • pnpm run test:e2e mini-cart-template-part.block_theme.spec.ts --ui
  • pnpm run test:e2e mini-cart-template-part.block_theme.spec.ts --headed
  • pnpm run test:e2e mini-cart-template-part.block_theme.spec.ts --debug

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Update docs on how to run Playwright e2e commands for WC Blocks.

@Aljullu Aljullu added focus: e2e tests Issues related to e2e tests team: Kirigami & Origami labels Jan 18, 2024
@Aljullu Aljullu self-assigned this Jan 18, 2024
@Aljullu Aljullu marked this pull request as ready for review January 18, 2024 11:34
@Aljullu Aljullu force-pushed the fix/blocks-e2e-pnpm-parameters branch from 4ffc08f to 06ed80c Compare January 18, 2024 11:35
@woocommercebot woocommercebot requested review from a team and thealexandrelara and removed request for a team January 18, 2024 11:36
@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. and removed focus: e2e tests Issues related to e2e tests labels Jan 18, 2024
Copy link
Contributor

Hi @thealexandrelara,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Test Results Summary

Commit SHA: 22e2234

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests28200502876m 37s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@thealexandrelara thealexandrelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! All the commands are working as expected, so I'm approving this PR!

Regarding the testing instructions, do you think it is worth mentioning that these commands should be run inside the plugins/woocommerce-blocks folder?

@Aljullu
Copy link
Contributor Author

Aljullu commented Jan 22, 2024

Regarding the testing instructions, do you think it is worth mentioning that these commands should be run inside the plugins/woocommerce-blocks folder?

Good point! I just updated it. 🙂

@Aljullu Aljullu force-pushed the fix/blocks-e2e-pnpm-parameters branch from 06ed80c to 22e2234 Compare January 22, 2024 09:41
@Aljullu Aljullu merged commit 550bfe3 into trunk Jan 22, 2024
40 checks passed
@Aljullu Aljullu deleted the fix/blocks-e2e-pnpm-parameters branch January 22, 2024 10:21
@github-actions github-actions bot added this to the 8.6.0 milestone Jan 22, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 22, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 22, 2024
opr pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants