New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WC Blocks Playwright tests docs so we pass parameters correctly to PNPM scripts #43779
Conversation
4ffc08f
to
06ed80c
Compare
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 22e2234
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! All the commands are working as expected, so I'm approving this PR!
Regarding the testing instructions, do you think it is worth mentioning that these commands should be run inside the plugins/woocommerce-blocks
folder?
Good point! I just updated it. 🙂 |
…y to PNPM scripts
06ed80c
to
22e2234
Compare
Changes proposed in this Pull Request:
In #43650 we updated the WC Blocks Playwright docs to use
pnpm
instead ofnpm
, but I didn't update how the parameters are passed, so they were ignored. I needed to change from:pnpm run test:e2e -- --headed
to:
pnpm run test:e2e --headed
This PR fixes that.
How to test the changes in this Pull Request:
Note: no need to test this for the release.
plugins/woocommerce-blocks
folder, runpnpm run test:e2e --ui
,pnpm run test:e2e --headed
,pnpm run test:e2e --debug
and verify all of them work as expected. Tip: no need to run all tests to verify the commands work, you can simply run one of them. Ie:pnpm run test:e2e mini-cart-template-part.block_theme.spec.ts --ui
pnpm run test:e2e mini-cart-template-part.block_theme.spec.ts --headed
pnpm run test:e2e mini-cart-template-part.block_theme.spec.ts --debug
Changelog entry
Significance
Type
Message
Comment
Update docs on how to run Playwright e2e commands for WC Blocks.