Move Cart, Checkout and Order Confirmation template customization tests to the parameterized tests file #43992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
commented
Jan 23, 2024
| }, | ||
| { | ||
| visitPage: async ( { frontendUtils, page } ) => { | ||
| const checkoutPage = new CheckoutPage( { page } ); |
There was a problem hiding this comment.
I don't know if this is the best way to create the CheckoutPage() object, but it was the cleanest way I could find without having to extend the test object of all tests. 🤔
Test Results SummaryCommit SHA: 3eafde5
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
…ts to the parameterized tests file
Aljullu
force-pushed
the
update/cart-checkout-order-confirmation-templates-to-parameterized-tests
branch
from
3fb6e64
to
72170b4
Compare
Aljullu
force-pushed
the
update/cart-checkout-order-confirmation-templates-to-parameterized-tests
branch
from
44b9ce3
to
7bb917e
Compare
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
Hi @roykho, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
roykho
requested changes
Jan 23, 2024
plugins/woocommerce-blocks/tests/e2e/tests/templates/order-confirmation.block_theme.spec.ts
Show resolved
Hide resolved
Aljullu
deleted the
update/cart-checkout-order-confirmation-templates-to-parameterized-tests
branch
github-actions
bot
added
the
needs: analysis
alopezari
added
status: analysis complete
opr
pushed a commit
that referenced
this pull request
Jan 25, 2024
…ts to the parameterized tests file (#43992) * Move Cart, Checkout and Order Confirmation template customization tests to the parameterized tests file * Add changefile(s) from automation for the following project(s): woocommerce-blocks * Clean up order-confirmation.block_theme.spec.ts file --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In #43778, we converted block templates tests to parameterized tests, but it didn't include Cart, Checkout and Order Confirmation templates tests.
How to test the changes in this Pull Request:
Note: no need to test this for the release.
Changelog entry
Significance
Type
Message
Comment
Move Cart, Checkout and Order Confirmation template customization tests to the parameterized tests file