Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert block templates tests to parametized tests #43778

Merged
merged 3 commits into from Jan 18, 2024

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jan 18, 2024

Changes proposed in this Pull Request:

As done in #43650, this PR converts user-customization tests for block templates into parametized tests, which helps reduce code repetition a lot.

How to test the changes in this Pull Request:

Note: no need to test this for the release.

  1. Verify Playwright e2e tests pass.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Convert block templates tests to parametized tests

@Aljullu Aljullu added focus: template Issue related to WooCommerce templates. team: Kirigami & Origami labels Jan 18, 2024
@Aljullu Aljullu self-assigned this Jan 18, 2024
Copy link
Contributor

github-actions bot commented Jan 18, 2024

Test Results Summary

Commit SHA: 1f960e0

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests265001802835m 31s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@Aljullu Aljullu force-pushed the update/block-template-tests-parametized branch from b63a10e to 1f960e0 Compare January 18, 2024 11:25
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 18, 2024
@Aljullu Aljullu marked this pull request as ready for review January 18, 2024 12:00
@woocommercebot woocommercebot requested review from a team and albarin and removed request for a team January 18, 2024 12:00
Copy link
Contributor

Hi @albarin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Aljullu Aljullu merged commit 91d0e16 into trunk Jan 18, 2024
45 checks passed
@Aljullu Aljullu deleted the update/block-template-tests-parametized branch January 18, 2024 12:29
@github-actions github-actions bot added this to the 8.6.0 milestone Jan 18, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 18, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: template Issue related to WooCommerce templates. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants