Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes strpos in ComparisonOperation for PHP 8 #44007

Merged
merged 3 commits into from Jan 24, 2024
Merged

Fixes strpos in ComparisonOperation for PHP 8 #44007

merged 3 commits into from Jan 24, 2024

Conversation

ilyasfoo
Copy link
Contributor

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. In your environment, use PHP 8.2.*
  2. Set up a fresh site
  3. Go to WooCommerce
  4. Skip setup wizard
  5. Observe you're able to load homescreen without any crashes
  6. Go to WooCommerce > Settings > Advanced > Woo.com
  7. Disable Display suggestions within WooCommerce checkbox
  8. Save
  9. Go back to WooCommerce > Home
  10. Click on Set up payments
  11. Observe no crash or UI issues

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited

Hi @jorgeatorres, @chihsuan, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@ilyasfoo ilyasfoo requested review from a team, chihsuan and moon0326 January 23, 2024 16:59
ilyasfoo
ilyasfoo commented Jan 23, 2024
View reviewed changes
plugins/woocommerce/src/Admin/Features/PaymentGatewaySuggestions/DefaultPaymentGateways.php
@@ -968,7 +968,7 @@ public static function get_rules_selling_offline() {
'option_name' => 'woocommerce_onboarding_profile',
'operation' => 'in',
'value' => array( 'no_im_selling_offline', 'im_selling_both_online_and_offline' ),
'default' => array(),
'default' => '',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defalt value is meant to be a string

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited

Test Results Summary

Commit SHA: b4ac1d2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests28900402936m 25s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

moon0326
moon0326 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

@ilyasfoo ilyasfoo closed this Jan 23, 2024
@ilyasfoo ilyasfoo reopened this Jan 23, 2024
@ilyasfoo ilyasfoo merged commit f85d275 into trunk Jan 24, 2024
73 of 76 checks passed
@ilyasfoo ilyasfoo deleted the fix/comparison-operator-strpos-and-remote-payment-suggestions branch January 24, 2024 00:42
@github-actions github-actions bot added this to the 8.6.0 milestone Jan 24, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 24, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 24, 2024
@ilyasfoo ilyasfoo mentioned this pull request Jan 24, 2024
Merged
11 tasks
opr pushed a commit that referenced this pull request Jan 25, 2024
@ilyasfoo @opr
Fixes strpos in ComparisonOperation for PHP 8 (#44007)
7a3d5f8 
* Fixes

* Changelog

* Add breaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moon0326 moon0326 moon0326 approved these changes

@jorgeatorres jorgeatorres Awaiting requested review from jorgeatorres

@chihsuan chihsuan Awaiting requested review from chihsuan chihsuan was automatically assigned from woocommerce/ghidorah

Assignees
No one assigned
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilyasfoo @moon0326 @alopezari