Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MiniCart.php #44011

Closed
wants to merge 2 commits into from
Closed

Conversation

niharikamahajan02
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #44006

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Jan 23, 2024
@woocommercebot woocommercebot requested review from a team and Konamiman and removed request for a team January 23, 2024 17:45
Copy link
Contributor

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@mikejolley mikejolley mentioned this pull request Jan 24, 2024
11 tasks
@mikejolley
Copy link
Member

Looks good. I have picked this PR into #44042 so tests can run. Thank you for the contribution.

@nielslange nielslange removed the request for review from Konamiman January 25, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini cart block second icon type have an html typo.
2 participants