Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG markup in miniCartIcon #44042

Merged
merged 2 commits into from Jan 25, 2024
Merged

Fix SVG markup in miniCartIcon #44042

merged 2 commits into from Jan 25, 2024

Conversation

mikejolley
Copy link
Member

Submission Review Guidelines:

Changes proposed in this Pull Request:

Picked from #44011 (added changelog, testing instructions, and allowing CI to run).

Closes #44011
Closes #44006

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Add Mini Cart Block to a page
  2. Change the icon to "bag" and save changes
  3. View frontend. Confirm icon renders correctly

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@mikejolley mikejolley self-assigned this Jan 24, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 24, 2024
@woocommercebot woocommercebot requested review from a team and nielslange and removed request for a team January 24, 2024 16:09
@mikejolley mikejolley mentioned this pull request Jan 24, 2024
10 tasks
Copy link
Contributor

Hi @nielslange,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Test Results Summary

Commit SHA: a860d98

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests28700602936m 31s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving #44011 into this PR. The change looks good and it works as expected. Let's ship #44011, @mikejolley.

@mikejolley mikejolley merged commit 538e45c into trunk Jan 25, 2024
50 checks passed
@mikejolley mikejolley deleted the fix/mini-cart-svg-44006 branch January 25, 2024 11:03
@github-actions github-actions bot added this to the 8.7.0 milestone Jan 25, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 25, 2024
@veljkho veljkho added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini cart block second icon type have an html typo.
4 participants