[Experimental] Utilize WP generated class names when styling new active filters block. #44069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
tjcafferkey
and removed request for
a team
|
Hi @dinhtungdu, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
samueljseay
commented
Jan 25, 2024
| @@ -159,7 +158,7 @@ private function render_chip_item( $args ) { | |||
|
|
|||
| $remove_label = sprintf( 'Remove %s filter', wp_strip_all_tags( $title ) ); | |||
| ?> | |||
| <li class="wc-block-active-filters__list-item"> | |||
| <li class="list-item"> | |||
| <span class="is-removable wc-block-components-chip wc-block-components-chip--radius-large"> | |||
There was a problem hiding this comment.
The only thing I left alone were these components chip classes. I assume they're borrowing styles from another component with some conditional overrides.
samueljseay
requested review from
dinhtungdu
and removed request for
tjcafferkey
…mmerce-blocks, woocommerce
Test Results SummaryCommit SHA: e2240f5
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
This was referenced Jan 25, 2024
dinhtungdu
approved these changes
Jan 26, 2024
github-actions
bot
added
the
needs: analysis
veljkho
added
status: analysis complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
@dinhtungdu and I agreed that we don't need to create our own unique class names or use bem style syntax, its overly verbose and doesn't add anything.
Instead we scope all styles to the class name generated for the block by WP, and also remove the BEM style prefix from any scoped class names. (To keep PR's small and testable I'm addressing one block at a time.)
Additionally, I noticed a lot of copy pasted styles from the old block that we don't use or need.
This is part of #43167
How to test the changes in this Pull Request:
Changelog entry
Significance
Type
Message
[Experimental] Utilize WP generated class names when styling new active filters block.
Comment