Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "can view product review" test #44077

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Add "can view product review" test #44077

merged 5 commits into from
Jan 26, 2024

Conversation

Stojdza
Copy link
Contributor

@Stojdza Stojdza commented Jan 25, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/woocommerce-quality/issues/608

Adding a test to check product reviews as merchant.

At the beginning of the test, I create a product and then add a review to the product (all of these via an API call). Eventually, I verify with expect that the product's name and review are listed.

Adding a timestamp to the product name and review should assure us we're checking the right thing.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Code review.
  2. Check flow - is there anything else that should be added or asserted?
  3. Run pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/product-reviews.spec.js and make sure that the test is passing.
  4. CI jobs should be green.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Add test to check product reviews.

Comment

@Stojdza Stojdza added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: e2e tests Issues related to e2e tests labels Jan 25, 2024
@Stojdza Stojdza requested review from a team January 25, 2024 11:04
@Stojdza Stojdza self-assigned this Jan 25, 2024
Copy link
Contributor

Hi , @woocommerce/solaris, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Test Results Summary

Commit SHA: 53812d5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests288001002986m 18s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! There are a couple of other things we should check -- the rating and the email/name of the reviewer would be good to assert too -- just to make sure that there's nothing getting messed up with data storage.

Screenshot 2024-01-25 at 1 24 33 PM

I'm approving so that you can merge as soon as those are added!

@Stojdza
Copy link
Contributor Author

Stojdza commented Jan 26, 2024

This looks good! There are a couple of other things we should check -- the rating and the email/name of the reviewer would be good to assert too -- just to make sure that there's nothing getting messed up with data storage.

Added in 53812d5

@Stojdza Stojdza merged commit 5e87527 into trunk Jan 26, 2024
30 checks passed
@Stojdza Stojdza deleted the e2e/check-product-review branch January 26, 2024 16:06
@github-actions github-actions bot added this to the 8.7.0 milestone Jan 26, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 26, 2024
@veljkho veljkho added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants