Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for password-protected Single Product block template #44304

Merged
merged 3 commits into from Feb 5, 2024

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Feb 2, 2024

Changes proposed in this Pull Request:

Closes #44297.

This PR adds e2e tests to verify the Single Product block template displays the password form when a product is password-protected.

How to test the changes in this Pull Request:

Note: no need to test this for the release.

  1. Verify e2e tests pass.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Add e2e tests for password-protected Single Product block template

@Aljullu Aljullu self-assigned this Feb 2, 2024
@Aljullu Aljullu added focus: template Issue related to WooCommerce templates. team: Kirigami & Origami labels Feb 2, 2024
@Aljullu Aljullu force-pushed the fix/44297-single-product-password-test branch from 9c83cea to 441f965 Compare February 2, 2024 11:34
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Test Results Summary

Commit SHA: 08de701

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests1830012603095m 18s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 2, 2024
@Aljullu Aljullu force-pushed the fix/44297-single-product-password-test branch from d3b084a to 613a3c2 Compare February 2, 2024 14:23
@Aljullu Aljullu force-pushed the fix/44297-single-product-password-test branch from 613a3c2 to 08de701 Compare February 2, 2024 16:22
@Aljullu Aljullu marked this pull request as ready for review February 2, 2024 19:51
@woocommercebot woocommercebot requested review from a team and albarin and removed request for a team February 2, 2024 19:51
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Hi @albarin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@Aljullu Aljullu merged commit 097bd5c into trunk Feb 5, 2024
45 checks passed
@Aljullu Aljullu deleted the fix/44297-single-product-password-test branch February 5, 2024 09:47
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 5, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 5, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 5, 2024
samueljseay pushed a commit that referenced this pull request Feb 6, 2024
…44304)

* Add e2e tests for password-protected Single Product block template

* Add changefile(s) from automation for the following project(s): woocommerce-blocks

* Fix tests

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: template Issue related to WooCommerce templates. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to verify the Single Product block template shows the password form on password-protected products
3 participants