Improve password-protected Single Product block template to verify correct template is displayed after correct password is introduced #44452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
focus: template
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
Hi @albarin, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 377855a
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
e2e tests are currently failing, but they will be fixed in #44454. |
…rrect template is displayed after correct password is introduced
Aljullu
force-pushed
the
update/single-product-password-test-correct
branch
from
254637e
to
7a7417f
Compare
github-actions
bot
added
the
plugin: woocommerce
github-actions
bot
added
the
needs: analysis
alopezari
added
status: analysis complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Follow-up of #44304.
In #44304 we added a test to verify that if a product is password-protected, we display the template with the password field. This PR expands that test to verify that if the user introduces the correct password, then the default template is displayed.
How to test the changes in this Pull Request:
Note: no need to test this for the release.
Changelog entry
Significance
Type
Message
Comment
Improve password-protected Single Product block template to verify correct template is displayed after correct password is introduced