Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests due to duplicate rows when clearing customizations #44454

Merged
merged 2 commits into from Feb 8, 2024

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Feb 8, 2024

Changes proposed in this Pull Request:

There are some tests failing in trunk because when we try to revert template customizations from the automated tests, there are two rows which match the Single Product text (Single Product and Single Product Belt). That causes the tests to fail because there are two matches for the locator.

This PR makes the locator more specific, so there is only one match even if two templates contain the same words.

How to test the changes in this Pull Request:

Note: no need to test this for the release.

  1. Verify e2e tests pass.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Fix block template e2e tests due to duplicate rows when clearing customizations

@Aljullu Aljullu self-assigned this Feb 8, 2024
@Aljullu Aljullu added focus: template Issue related to WooCommerce templates. team: Kirigami & Origami labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test Results Summary

Commit SHA: 0d71318

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests630025103145m 35s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@Aljullu Aljullu force-pushed the fix/e2e-templates-tests-duplicate-rows branch from fca1aaf to 65cc9f5 Compare February 8, 2024 13:53
@Aljullu Aljullu marked this pull request as ready for review February 8, 2024 14:23
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 8, 2024
@woocommercebot woocommercebot requested review from a team and thealexandrelara and removed request for a team February 8, 2024 14:23
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hi @thealexandrelara,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@thealexandrelara thealexandrelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix and for working on this! 🚀

@Aljullu Aljullu merged commit f65a7e4 into trunk Feb 8, 2024
46 checks passed
@Aljullu Aljullu deleted the fix/e2e-templates-tests-duplicate-rows branch February 8, 2024 22:15
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 8, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 8, 2024
@veljkho veljkho added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: template Issue related to WooCommerce templates. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants