Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Beta label to Product Filters E2E tests #44564

Merged
merged 2 commits into from Feb 12, 2024

Conversation

kmanijak
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

In #44487 the Beta label was added to Product Filters but the E2E tests were not updated hence they fail on other branches. This PR adds the Beta label to block names in E2E tests.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Pipelines passing especially "Blocks Playwright E2E tests - Normal"

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@woocommercebot woocommercebot requested review from a team and albarin and removed request for a team February 12, 2024 18:58
@kmanijak kmanijak added focus: e2e tests Issues related to e2e tests team: Kirigami & Origami block-type: filter blocks Issues related to all of the filter blocks. labels Feb 12, 2024
Copy link
Contributor

Hi @albarin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. and removed focus: e2e tests Issues related to e2e tests labels Feb 12, 2024
Copy link
Contributor

github-actions bot commented Feb 12, 2024

Test Results Summary

Commit SHA: 923fdb4

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests258005903176m 9s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@thealexandrelara thealexandrelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy fix on the e2e tests! I just double-checked to see if any other part was missing an update, but it seems you got everything. 🚀

@kmanijak kmanijak merged commit cc0d736 into trunk Feb 12, 2024
40 checks passed
@kmanijak kmanijak deleted the fix/product-filters-e2e-tests branch February 12, 2024 19:26
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 12, 2024
@samueljseay
Copy link
Contributor

@kmanijak so sorry this happened. I enabled auto-merge forgetting we don't have these tests as required. I'm going to request a change for that now. Thanks for fixing this on my behalf 🙇

@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-type: filter blocks Issues related to all of the filter blocks. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants