Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Add (Beta) suffix to block name of new filter blocks #44487

Merged
merged 4 commits into from Feb 12, 2024

Conversation

samueljseay
Copy link
Contributor

@samueljseay samueljseay commented Feb 9, 2024

Changes proposed in this Pull Request:

In preparation for releasing a beta release of the new filter blocks this renames them all to add a "(Beta)" suffix. I've added the suffix to the variants which control the insertion of these filter blocks but I've also added it to the blocks themselves for completeness.

This addresses the task Add (Beta) suffix to all blocks' name. of #43234

Note that this doesn't change that these blocks are still behind a feature flag and won't be available in a prod environment until we remove the feature flagging.

How to test the changes in this Pull Request:

There is nothing to test here really, CI smoke tests of filters passing will be enough 😄

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

[Experimental] Add (Beta) suffix to new filter blocks in prep to make them available for future release.

@woocommercebot woocommercebot requested review from a team and gigitux and removed request for a team February 9, 2024 02:50
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi @gigitux,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Test Results Summary

Commit SHA: eba0f58

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests271004603175m 31s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 12, 2024
@samueljseay samueljseay enabled auto-merge (squash) February 12, 2024 11:02
@samueljseay samueljseay merged commit 143388d into trunk Feb 12, 2024
35 of 36 checks passed
@samueljseay samueljseay deleted the dev/suffix-filter-blocks-beta branch February 12, 2024 11:15
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 12, 2024
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants