New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental] Add (Beta) suffix to block name of new filter blocks #44487
Conversation
…for beta release.
Hi @gigitux, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: eba0f58
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes proposed in this Pull Request:
In preparation for releasing a beta release of the new filter blocks this renames them all to add a "(Beta)" suffix. I've added the suffix to the variants which control the insertion of these filter blocks but I've also added it to the blocks themselves for completeness.
This addresses the task
Add (Beta) suffix to all blocks' name.
of #43234Note that this doesn't change that these blocks are still behind a feature flag and won't be available in a prod environment until we remove the feature flagging.
How to test the changes in this Pull Request:
There is nothing to test here really, CI smoke tests of filters passing will be enough 😄
Changelog entry
Significance
Type
Message
Comment
[Experimental] Add (Beta) suffix to new filter blocks in prep to make them available for future release.