New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental] Refresh product collections that don't support the interactivity API #44631
Conversation
Hi @dinhtungdu, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: acd6a55
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is testing great for me. I only have some comments on the testing instructions:
- This PR doesn't have the
Experimental
prefix, the QA team will pick it up for testing. We should state that this can't be tested without Introduce the new front-end filter blocks in beta state #44489. - In the testing instructions you mentioned:
Create a page or template with the interactivity filters nested inside "Products (Beta)". There will be warning not to do this for each block, but thats ok.
I think we should also mention here that even new filter blocks work inside Products (Beta)
, we don't have a plan to remove the warning when used with Products (Beta)
block or update the copy (which mentions the Product Collection only) because the former is being deprecated soon.
Approving because this is working and testing as expected.
@dinhtungdu yes true, 🤔 should we maybe just add
When you say mention, you just want to add this detail in the PR description? Maybe its not too important if we mark this experimental, but of course happy to add more explanation. |
@samueljseay Yeah, sounds good to me.
Yes, I mean the description of the PR. But if we mark this one as experimental, then I agree that it's not necessary. |
…mmerce-blocks, woocommerce
Changes proposed in this Pull Request:
The new interactivity API filter blocks don't refresh the page when updating a filter (in most cases) because the new product collection can handle that.
But we need to still support classic template and the soon to be deprecated "Products (Beta)" block. In this PR we add a flag to client side data for those cases, we use that flag to determine if a full page refresh is needed. Bottom line: if at least one of these is present on a page we will do full page refresh when updating the filters. This will be easy to change later as we do all the navigation for interactivity filters from a single function.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
[Experimental] Add a flag that will force page refresh when combining interactivity filters with classic template or products (beta) blocks.
Comment