Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the new front-end filter blocks in beta state #44489

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

samueljseay
Copy link
Contributor

@samueljseay samueljseay commented Feb 9, 2024

Changes proposed in this Pull Request:

In this PR all the feature gating around the new front-end filter blocks is removed, allowing users to use the new front-end filter blocks. This combined with #44487 will release these new blocks to production in a beta state.

How to test the changes in this Pull Request:

  1. Do a production build of WooCommerce blocks (or run this on JN - which is prod by default right now)
  2. Search for the new filter blocks in the GB inserter such as Product Filters: ... and see that these filter blocks are available for insertion.
  3. Smoke test that inserting and using them works as expected.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Release the new product collection filter blocks in a beta state.

Comment

@samueljseay samueljseay added this to the 8.7.0 milestone Feb 9, 2024
@woocommercebot woocommercebot requested a review from a team February 9, 2024 06:37
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 9, 2024
@woocommercebot woocommercebot requested review from ObliviousHarmony and removed request for a team February 9, 2024 06:37
@github-actions github-actions bot removed this from the 8.7.0 milestone Feb 9, 2024
@samueljseay samueljseay removed the request for review from ObliviousHarmony February 9, 2024 06:37
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi @dinhtungdu,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Test Results Summary

Commit SHA: 70a6e9b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests322002303456m 46s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@samueljseay samueljseay changed the title [WIP] Introduce the new front-end filter blocks in beta state Introduce the new front-end filter blocks in beta state Feb 9, 2024
Base automatically changed from dev/suffix-filter-blocks-beta to trunk February 12, 2024 11:15
@samueljseay samueljseay reopened this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter blocks: Beta release Filter blocks: Dropdown should be collapsed initially even on slow networks
2 participants