New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handling and tests for ShippingPartnerSuggestions #44641
Conversation
…ed generic error handling for RemoteFreeExtension evaluator
Hi @chihsuan, @moon0326, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 593364e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well 👍 🚀
…ling-shipping-partners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good and tested well! 👍
Changes proposed in this Pull Request:
Partially closes #44248.
How to test the changes in this Pull Request:
Test shipping task
United Kingdom
country in onboarding wizardAdd shipping costs
taskShipStation
andsendcloud
is shownTesting transient when specs are valid
wp-cli
wp transient get timeout_woocommerce_admin_shipping_partner_suggestions_specs
Testing transient when specs are invalid
wp transient delete woocommerce_admin_shipping_partner_suggestions_specs
wp transient delete timeout_woocommerce_admin_shipping_partner_suggestions_specs
wp option delete woocommerce_admin_created_default_shipping_zones
wp option delete woocommerce_admin_reviewed_default_shipping_zones
WooCommerce > Settings > Shipping
and delete all shipping zones.Add shipping costs
taskwp transient get timeout_woocommerce_admin_shipping_partner_suggestions_specs
Changelog entry
Significance
Type
Message
Comment