[Experimental] Fix a bug in new attribute filter where we didn't set the attribute from content panel

[samueljseay]

Changes proposed in this Pull Request:

Solves #44756

When implementing the attribute filter block, we missed that it was not setting the attribute when editing it from the inspector "content" panel. This fixes that bug.

How to test the changes in this Pull Request:

1. Add the new product filter: attribute (beta) filter block to a page or template
2. Choose an attribute to filter by and click done.
3. Select the block, now open inspector panel, go to "content", try changing the attribute to see it update, also confirm search filtering of the attributes works as before.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

[Experimental] Fix a bug in new attribute filter where we didn't set the attribute from content panel

Comment

[github-actions]

Hi @dinhtungdu, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: f6d9db9

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 36s
E2E Tests	327	0	0	13	0	340	8m 49s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[dinhtungdu]

Code changes look good to me. Can you also fix other issues listed in #44756 in this PR as they're all related to the Content Settings panel?

[samueljseay]

@dinhtungdu I've addressed the icon styling issue. (Note it was present in the old filter too, so this fixes it for both).

There was no real exact prior art for where it should be positioned so I've just centered everything:

Before:

After:

As for these two:

The Content Settings may not a good label for this panel.
We may not need a separate panel for the attribute selector.

I've left some questions on the issue about this.

[dinhtungdu]

I can confirm the styling issue is fixed and attribute can be set from the Content Settings panel now. Thanks for working on this!