Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Fix: regression introduced in #44757 that breaks the inspector settings of the new attribute filter block #45276

Merged
merged 1 commit into from Mar 5, 2024

Conversation

dinhtungdu
Copy link
Member

Submission Review Guidelines:

Changes proposed in this Pull Request:

In #44757, we accidentally removed the setAttributes definition that breaks the inspector setting panel. This PR fixes that regression.

Note that in both the trunk and this PR, all attribute filter blocks are rendered when a new attribute is selected from either the Content Setting panel or the Attribute Selector.

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Add the new Attribute Filter block to the page (Product Filter: Attribute (Beta)).
  2. Ensure all inspector settings can be changed.
  3. See no error in the console.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@dinhtungdu dinhtungdu self-assigned this Mar 4, 2024
@dinhtungdu dinhtungdu added the block: filter by attribute Issues related to the Filter by Attribute block. label Mar 4, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 4, 2024
@woocommercebot woocommercebot requested a review from a team March 4, 2024 10:19
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Hi @samueljseay, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Test Results Summary

Commit SHA: eb9dc63

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 40s
E2E Tests338001303517m 19s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@samueljseay samueljseay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for spotting and fixing this so quickly 🙇🏻

@dinhtungdu
Copy link
Member Author

Side Effect E2E workflows are failing but it's also failing on trunk, this PR doesn't touch or related to any test case in Side Effect suite so I'm merging this one with failed workflows.

@dinhtungdu dinhtungdu merged commit 91272dd into trunk Mar 5, 2024
52 of 54 checks passed
@dinhtungdu dinhtungdu deleted the followup/44757 branch March 5, 2024 04:09
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 5, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 5, 2024
@alvarothomas alvarothomas added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 6, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
…nspector settings of the new attribute filter block (#45276)

Fix: regression introduced in #44757 that breaks the inspector settings of the new attribute filter block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: filter by attribute Issues related to the Filter by Attribute block. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants