[CYS] Update footer and homepage copy #44800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: e2e tests
albarin
changed the base branch from
trunk
to
44700-cys-update-sidebar-links
github-actions
bot
removed
the
plugin: woocommerce
Test Results SummaryCommit SHA: 2c2c20c
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Hi @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
nefeline
requested changes
Feb 20, 2024
There was a problem hiding this comment.
@albarin I've just noticed that on this branch there's a regression with the templates, they are all displayed with the same order they used to before your changes on a very recent PR:
On Trunk:
On this PR:
do you mind taking a look?
github-actions
bot
added
focus: documentation
albarin
force-pushed
the
44700-cys-update-sidebar-links
branch
from
1fcbf60
to
d903b02
Compare
albarin
force-pushed
the
update-footer-homepage-copy
branch
from
f793559
to
79edb0e
Compare
github-actions
bot
removed
tool: monorepo infrastructure
Good catch, the base branch was not up to date, I've rebased, it should be good now if you want to have another look @nefeline |
albarin
force-pushed
the
update-footer-homepage-copy
branch
from
06ddd34
to
167a895
Compare
github-actions
bot
added
the
needs: analysis
alopezari
added
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Update assembler sidebar link when no AI available * Update the sidebar section title depending on the flow * Revert unnecessary changes * Add changefile(s) from automation for the following project(s): woocommerce * Add missing text domain * Fix test * Tweak the footer section copy * Update the design homepage section description * Chage footer description only on Core * Add changefile(s) from automation for the following project(s): woocommerce * Update copy * Fix code duplication --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR updates the footer and homepage sections of the assembler sidebar to match the designs.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Testerplugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag.WooCommerce > Home, click onStart customizing, and finish the flow.Changelog entry
Significance
Type
Message
CYS - Updates the footer and homepage sections of the assembler sidebar.
Comment