[e2e tests] Fix command pallete test failing with Gutenberg active

[adimoldovan]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes #45124 .

Fixed tests command-palette.spec.js broken by a label change in Gutenberg.

I took this occasion to add some improvements to this spec:

• introduced fixtures to replace the beforeAll/afterAll hooks.
• added a new function to disable the editor welcome guide by setting a pref instead of waiting for the modal and clicking the close button. This shaves off 5 seconds useless waiting on every test.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

The tests should pass with both Gutenberg active and inactive.

Locally:

1. Run without Gutengerng: pnpm env:restart && pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/command-palette.spec.js
2. Install Gutenberg
3. Run again: pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/command-palette.spec.js

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 9c43938

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	319	0	0	24	0	343	6m 53s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[rrennick]

added a new function to disable the editor welcome guide by setting a pref instead of waiting for the modal and clicking the close button. This shaves off 5 seconds useless waiting on every test.

Is there still some place in the E2E tests where the modal is being dismissed through the browser? The concern with completely eliminating this by setting a pref is that the modal itself is not longer tested in E2E.

[adimoldovan]

Is there still some place in the E2E tests where the modal is being dismissed through the browser? The concern with completely eliminating this by setting a pref is that the modal itself is not longer tested in E2E.

Good question @rrennick. At this point, yes, there are many other tests that are dismissing the modal through the browser.
But, I'm actually working on another PR (#45132) to remove all those. I think this is a good discussion to have in there.

[rrennick]

Looks good.