[e2e tests] Improve execution time by disabling the welcomeGuide feature instead of waiting for the modal

[adimoldovan]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Every time the page or the post editor is visited the closeWelcomeModal function waits 5 seconds for the welcome tour modal to be displayed and closes it. Most of the times the modal is not even being displayed, as it was previously dismissed.

This PR adds a function to disable the modal by setting the welcomeGuide feature. It should save 5 seconds of most editor page visits.

I also removed some unnecessary waitFor('networkidle') calls that were slowing down the tests.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Run all affected tests, they should pass.

pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/create-cart-block.spec.js ./tests/e2e-pw/tests/shopper/cart-block-calculate-shipping.spec.js ./tests/e2e-pw/tests/shopper/cart-block-coupons.spec.js ./tests/e2e-pw/tests/shopper/cart-block.spec.js ./tests/shopper/cart-checkout-block-calculate-tax.spec.js ./tests/e2e-pw/tests/shopper/mini-cart.spec.js ./tests/e2e-pw/tests/shopper/shop-products-filter-by-price.spec.js, ./tests/e2e-pw/tests/merchant/create-post.spec.js, ./tests/e2e-pw/tests/merchant/create-page.spec.js, ./tests/e2e-pw/tests/shopper/product-tags-attributes.spec.js

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: a0fbc43

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	306	0	0	41	0	347	7m 30s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[rrennick]

@adimoldovan This branch has merge conflicts.

[adimoldovan]

Addressing here @rrennick's #45121 (comment) from #45121

Is there still some place in the E2E tests where the modal is being dismissed through the browser? The concern with completely eliminating this by setting a pref is that the modal itself is not longer tested in E2E.

With changes in this PR, unless I missed any, there shouldn't be any places left where the modal is being dismissed through the browser. I'm ok with that, because that modal is not a Woo feature, and not something critical we want to test.
And if we decide to test it, I would rather have a dedicated test to it.
I'm open to other approaches though.

[rrennick]

because that modal is not a Woo feature, and not something critical we want to test.

Thanks for that clarification. This is a nice improvement.