List Custom Fields for New Product Editor #45360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdperez86
added
focus: new product ux
|
Hi @octaedro, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: f1969c4
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
github-actions
bot
added
the
plugin: woocommerce
mdperez86
force-pushed
the
add/44169-list
branch
from
0664c66
to
10252ff
Compare
11 tasks
octaedro
reviewed
Mar 11, 2024
| 'description' => sprintf( | ||
| /* translators: %1$s: Custom fields guide link opening tag. %2$s: Custom fields guide link closing tag. */ | ||
| __( 'Custom fields can be used in a variety of ways, such as sharing more detailed product information, showing more input fields, or internal inventory organization. %1$sRead more about custom fields?%2$s', 'woocommerce' ), | ||
| '<a href="https://woo.com" target="_blank" rel="noreferrer">', |
There was a problem hiding this comment.
The link in the design is pointing to woo.com but I think that it would be better to point to the WordPress custom fields documentation.
There was a problem hiding this comment.
Yes, agree! That's the correct link, thank you!
…d block definition since it is not used
mdperez86
force-pushed
the
add/44169-list
branch
from
92634f7
to
f1969c4
Compare
octaedro
reviewed
Mar 11, 2024
| "lock": false, | ||
| "__experimentalToolbar": false | ||
| }, | ||
| "usesContext": [ "postType" ], |
There was a problem hiding this comment.
I think that we can remove this.
octaedro
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Good job @mdperez86! This is testing well on my end and the code looks good. I just left one comment that could be addressed in the other PR.
github-actions
bot
added
the
needs: analysis
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Create woocommerce/product-custom-fields block * Register woocommerce/product-custom-fields block * Add product-custom-fields block to the simple product template * Create useCustomFields hook * Create empty state * Create CustomFields component * Add custom fields table * Add custom field remove button * Hide the custom fields table base on the toggle value * Remove non list features * Add changelog files * Fix linter errors * Fix empty state styles * Fix php linter error * Remove context from the woocommerce/product-custom-fields-toggle-field block definition since it is not used * Change url for the Read more about custom fields
alopezari
added
focus: new product ux
nigeljamesstevenson
added
the
release: highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Partially close #44169
Depends on #45291
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
New product editoris enabled under/wp-admin/admin.php?page=wc-settings&tab=advanced§ion=featuresproduct-custom-fieldsis enabled underFeaturestab from/wp-admin/tools.php?page=woocommerce-admin-test-helper(WooCommerce Beta Tester plugin) is requiredProducts->Add newfrom the left menu to create a new productOrganizationtabShow custom fieldstoggle should be shownCustom fieldssection listing the custom fields that belong to the editing product metasNOTE:
total_salesis automatically added as a custom field to each product in the classic editor. This field is not added or shown automatically in the new editor for now.Changelog entry
Significance
Type
Message
Comment